third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc - Issue 2880573002: Store border-*-style on SurroundData in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

Issue 2880573002: Store border-*-style on SurroundData in ComputedStyle (Closed)

Patch Set: Store border-*-style on SurroundData in ComputedStyle not BorderStyle Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

index c64cbe2947fe9eef83c5eca12d3052a590245266..34926a4a2dfe050a05a2e3c4ee83af2e956be006 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

@@ -361,10 +361,10 @@ TEST_F(NGLengthUtilsTest, testBorders) {

style_->SetBorderRightWidth(2);

style_->SetBorderBottomWidth(3);

style_->SetBorderLeftWidth(4);

- style_->SetBorderTopStyle(kBorderStyleSolid);

- style_->SetBorderRightStyle(kBorderStyleSolid);

- style_->SetBorderBottomStyle(kBorderStyleSolid);

- style_->SetBorderLeftStyle(kBorderStyleSolid);

+ style_->SetBorderTopStyle(EBorderStyle::kSolid);

+ style_->SetBorderRightStyle(EBorderStyle::kSolid);

+ style_->SetBorderBottomStyle(EBorderStyle::kSolid);

+ style_->SetBorderLeftStyle(EBorderStyle::kSolid);

style_->SetWritingMode(WritingMode::kVerticalLr);

RefPtr<NGConstraintSpace> constraint_space(