third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp - Issue 2880573002: Store border-*-style on SurroundData in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

Issue 2880573002: Store border-*-style on SurroundData in ComputedStyle (Closed)

Patch Set: Merge branch 'enumClass' into borderStyle Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

index fa7d7eece20025fcab387da35ab4199baaf35d50..a7d051ab98ba7edfad2e57a389d8eac04d168d6a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

@@ -17,10 +17,7 @@ void LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(

const ComputedStyle& old_style) {

if (!table.ShouldCollapseBorders())

return;

- if (old_style.Border() != table_part.StyleRef().Border() ||

- !old_style.BorderColorEquals(table_part.StyleRef()) ||

- !old_style.RadiiEqual(table_part.StyleRef()) ||

- !old_style.BorderSizeEquals(table_part.StyleRef()) ||

+ if (!old_style.BorderEquals(table_part.StyleRef()) ||

(diff.TextDecorationOrColorChanged() &&

table_part.StyleRef().HasBorderColorReferencingCurrentColor()))

table.InvalidateCollapsedBorders();