Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/platform/network/ParsedContentDispositionTest.cpp

Issue 2880543003: Implement a parser for Content-Disposition header fields (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/ParsedContentDispositionTest.cpp
diff --git a/third_party/WebKit/Source/platform/network/ParsedContentDispositionTest.cpp b/third_party/WebKit/Source/platform/network/ParsedContentDispositionTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..6cae10aa2530275b4faf05e67cb8201b2e16eb39
--- /dev/null
+++ b/third_party/WebKit/Source/platform/network/ParsedContentDispositionTest.cpp
@@ -0,0 +1,92 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "platform/network/ParsedContentDisposition.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+namespace {
+
+using Mode = ParsedContentDisposition::Mode;
+
+bool IsValid(const String& input, Mode mode = Mode::kNormal) {
+ return ParsedContentDisposition(input, mode).IsValid();
+}
+
+TEST(ParsedContentDispositionTest, TypeWithoutFilename) {
+ ParsedContentDisposition t("attachment");
+
+ EXPECT_TRUE(t.IsValid());
+ EXPECT_EQ("attachment", t.Type());
+ EXPECT_EQ(String(), t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, TypeWithFilename) {
+ ParsedContentDisposition t(" attachment ; x=y; filename = file1 ");
+
+ EXPECT_TRUE(t.IsValid());
+ EXPECT_EQ("attachment", t.Type());
+ EXPECT_EQ("file1", t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, TypeWithQuotedFilename) {
+ ParsedContentDisposition t("attachment; filename=\"x=y;y=\\\"\\pz; ;;\"");
+
+ EXPECT_TRUE(t.IsValid());
+ EXPECT_EQ("attachment", t.Type());
+ EXPECT_EQ("x=y;y=\"pz; ;;", t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, InvalidTypeWithoutFilename) {
+ ParsedContentDisposition t(" ");
+
+ EXPECT_FALSE(t.IsValid());
+ EXPECT_EQ(String(), t.Type());
+ EXPECT_EQ(String(), t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, InvalidTypeWithFilename) {
+ ParsedContentDisposition t("/attachment; filename=file1;");
+
+ EXPECT_FALSE(t.IsValid());
+ EXPECT_EQ(String(), t.Type());
+ EXPECT_EQ(String(), t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, CaseInsensitiveFilename) {
+ ParsedContentDisposition t("attachment; fIlEnAmE=file1");
+
+ EXPECT_TRUE(t.IsValid());
+ EXPECT_EQ("attachment", t.Type());
+ EXPECT_EQ("file1", t.Filename());
+}
+
+TEST(ParsedContentDispositionTest, Validity) {
+ EXPECT_TRUE(IsValid("attachment"));
+ EXPECT_TRUE(IsValid("attachment; filename=file1"));
+ EXPECT_TRUE(IsValid("attachment; filename*=UTF-8'en'file1"));
+ EXPECT_TRUE(IsValid(" attachment ;filename=file1 "));
+ EXPECT_TRUE(IsValid(" attachment "));
+ EXPECT_TRUE(IsValid("unknown-unknown"));
+ EXPECT_TRUE(IsValid("unknown-unknown; unknown=unknown"));
+
+ EXPECT_FALSE(IsValid("A/B"));
+ EXPECT_FALSE(IsValid("attachment\r"));
+ EXPECT_FALSE(IsValid("attachment\n"));
+ EXPECT_FALSE(IsValid("attachment filename=file1"));
+ EXPECT_FALSE(IsValid("attachment;filename=file1;"));
+ EXPECT_FALSE(IsValid(""));
+ EXPECT_FALSE(IsValid(" "));
+ EXPECT_FALSE(IsValid("\"x\""));
+ EXPECT_FALSE(IsValid("attachment;"));
+ EXPECT_FALSE(IsValid("attachment; "));
+ EXPECT_FALSE(IsValid("attachment; filename"));
+ EXPECT_FALSE(IsValid("attachment; filename;"));
+}
+
+} // namespace
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698