x509_certificate_model_openssl: implement GetCertNameOrNickname, GetTitle

x509_certificate_model_openssl: implement GetCertNameOrNickname, GetTitle

BUG=338887
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272776

[Ryan Sleevi, 2014-05-15 05:53:05]

Differences between the two should be resolved with the suggestion below

https://codereview.chromium.org/288053003/diff/1/chrome/common/net/x509_certi...
File chrome/common/net/x509_certificate_model_openssl.cc (right):

https://codereview.chromium.org/288053003/diff/1/chrome/common/net/x509_certi...
chrome/common/net/x509_certificate_model_openssl.cc:53: if
(X509_NAME_oneline(X509_get_subject_name(cert_handle), buf, sizeof(buf)))
1) X509_NAME_online is deprecated and has been for some time.
2) Using a fixed buffer is non-ideal.

Luckily, switching to X509_NAME_print_ex to a memory BIO will handle both cases.

[mattm, 2014-05-20 06:29:32]

> Differences between the two should be resolved with the suggestion below

Did you mean the differences between Openssl and NSS or between
GetCertNameOrNickname and GetTitle?
(openssl and nss aren't entirely resolved because openssl used emailaddress=
instead of E=)

https://codereview.chromium.org/288053003/diff/1/chrome/common/net/x509_certi...
File chrome/common/net/x509_certificate_model_openssl.cc (right):

https://codereview.chromium.org/288053003/diff/1/chrome/common/net/x509_certi...
chrome/common/net/x509_certificate_model_openssl.cc:53: if
(X509_NAME_oneline(X509_get_subject_name(cert_handle), buf, sizeof(buf)))
On 2014/05/15 05:53:05, Ryan Sleevi wrote:
> 1) X509_NAME_online is deprecated and has been for some time.
> 2) Using a fixed buffer is non-ideal.
> 
> Luckily, switching to X509_NAME_print_ex to a memory BIO will handle both
cases.

Done.

[Ryan Sleevi, 2014-05-20 18:23:31]

I was more concerned about the ordering and RFC correctness of it.

I'm fine with the E=/emailAddress= distinction.

LGTM

[mattm, 2014-05-22 18:10:40]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-05-22 18:13:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mattm@chromium.org/288053003/10001

[commit-bot: I haz the power, 2014-05-22 21:39:24]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-22 21:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 21:49:55]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[mattm, 2014-05-23 20:06:46]

On 2014/05/22 21:49:55, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_clang_dbg on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

So I updated the CL to remove the x509_certificate_model_openssl.cc and
x509_certificate_model_unittest.cc from the android build since
x509_certificate_model.cc was already being excluded. Is that reasonable?

[Ryan Sleevi, 2014-05-24 18:26:11]

lgtm

[commit-bot: I haz the power, 2014-05-26 04:02:32]

Change committed as 272776