Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: extensions/common/permissions/permissions_data.cc

Issue 288053002: Block content scripts from executing until user grants permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed test failures Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.cc
diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc
index 65359d9950954bd8496fa38b5d6b1dfff2da1c5f..a4fee8749fd9866c43f9bbce55b94691c6e28bd0 100644
--- a/extensions/common/permissions/permissions_data.cc
+++ b/extensions/common/permissions/permissions_data.cc
@@ -565,10 +565,12 @@ bool PermissionsData::RequiresActionForScriptExecution(
const Extension* extension) {
// For now, the user should be notified when an extension with all hosts
// permission tries to execute a script on a page. Exceptions for policy-
- // enabled and component extensions.
+ // enabled and component extensions, and extensions which are whitelisted to
+ // execute scripts everywhere.
return extension->ShouldDisplayInExtensionSettings() &&
!Manifest::IsPolicyLocation(extension->location()) &&
!Manifest::IsComponentLocation(extension->location()) &&
+ !CanExecuteScriptEverywhere(extension) &&
HasEffectiveAccessToAllHosts(extension);
}

Powered by Google App Engine
This is Rietveld 408576698