Issue 2880443005: Remove one more use of DillTarget.read that broke compiler/tool/generate_kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2880443005: Remove one more use of DillTarget.read that broke compiler/tool/generate_kernel. (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Johnni Winther

Target Ref:
refs/heads/master

Visibility:
Public.

Remove one more use of DillTarget.read that broke compiler/tool/generate_kernel. Also adds a test for that script. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dae30fe2869680847b8b6e9b41748535569ea7fb

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	A	pkg/compiler/tool/generate_kernel_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
	M	pkg/front_end/lib/src/fasta/fasta.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

3 years, 7 months ago (2017-05-12 17:37:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dae30fe2869680847b8b6e9b41748535569ea7fb (presubmit successful).