Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: ios/web/navigation/window_location_inttest.mm

Issue 2880443004: Marked WindowLocationTest.WindowLocationReload as flaky on device. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/window_location_inttest.mm
diff --git a/ios/web/navigation/window_location_inttest.mm b/ios/web/navigation/window_location_inttest.mm
index 28cd16df10ae6e100660f2a148f488fb79375917..efd90c2ccabb2c1bd7e7a4d2799fc8b26f98da27 100644
--- a/ios/web/navigation/window_location_inttest.mm
+++ b/ios/web/navigation/window_location_inttest.mm
@@ -202,7 +202,13 @@ TEST_F(WindowLocationTest, WindowLocationReplaceUnresolvable) {
}
// Tests that calling window.location.reload() causes an onload event to occur.
-TEST_F(WindowLocationTest, WindowLocationReload) {
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_WindowLocationReload WindowLocationReload
+#else
+#define MAYBE_WindowLocationReload FLAKY_WindowLocationReload
+#endif
+// TODO(crbug.com/721465): Enable this test on device.
+TEST_F(WindowLocationTest, MAYBE_WindowLocationReload) {
// Tap the window.location.reload() button.
ExecuteBlockAndWaitForLoad(window_location_url(), ^{
ASSERT_TRUE(web::test::TapWebViewElementWithId(web_state(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698