ui/views/window/dialog_delegate.cc - Issue 2880433002: views: don't snap dialogs with no buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 2880433002: views: don't snap dialogs with no buttons (Closed)

Patch Set: add unittest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/window/dialog_delegate.cc

diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc

index d354353c5db90c32b7bd1c53d52e5c4e3b7d99d3..d0a13e0090dfd7eff2e9a9b0a077bb7e01dbfc5d 100644

--- a/ui/views/window/dialog_delegate.cc

+++ b/ui/views/window/dialog_delegate.cc

@@ -133,7 +133,7 @@ void DialogDelegate::UpdateButton(LabelButton* button, ui::DialogButton type) {

}

bool DialogDelegate::ShouldSnapFrameWidth() const {

- return true;

+ return GetDialogButtons() != ui::DIALOG_BUTTON_NONE;

sky 2017/05/12 17:28:07 Would a better fix be to have BubbleDialogDelegate

}

int DialogDelegate::GetDialogButtons() const {