Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: ui/views/bubble/bubble_dialog_delegate.h

Issue 2880433002: views: don't snap dialogs with no buttons (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_ 5 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
6 #define UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_ 6 #define UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
7 7
8 #include "base/gtest_prod_util.h" 8 #include "base/gtest_prod_util.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "ui/views/bubble/bubble_border.h" 10 #include "ui/views/bubble/bubble_border.h"
(...skipping 21 matching lines...) Expand all
32 DEACTIVATION, 32 DEACTIVATION,
33 CLOSE_BUTTON, 33 CLOSE_BUTTON,
34 UNKNOWN, 34 UNKNOWN,
35 }; 35 };
36 36
37 ~BubbleDialogDelegateView() override; 37 ~BubbleDialogDelegateView() override;
38 38
39 // Create and initialize the bubble Widget(s) with proper bounds. 39 // Create and initialize the bubble Widget(s) with proper bounds.
40 static Widget* CreateBubble(BubbleDialogDelegateView* bubble_delegate); 40 static Widget* CreateBubble(BubbleDialogDelegateView* bubble_delegate);
41 41
42 // DialogDelegateView overrides:
43 bool ShouldSnapFrameWidth() const override;
44
42 // WidgetDelegateView overrides: 45 // WidgetDelegateView overrides:
43 BubbleDialogDelegateView* AsBubbleDialogDelegate() override; 46 BubbleDialogDelegateView* AsBubbleDialogDelegate() override;
44 bool ShouldShowCloseButton() const override; 47 bool ShouldShowCloseButton() const override;
45 ClientView* CreateClientView(Widget* widget) override; 48 ClientView* CreateClientView(Widget* widget) override;
46 NonClientFrameView* CreateNonClientFrameView(Widget* widget) override; 49 NonClientFrameView* CreateNonClientFrameView(Widget* widget) override;
47 const char* GetClassName() const override; 50 const char* GetClassName() const override;
48 51
49 // WidgetObserver overrides: 52 // WidgetObserver overrides:
50 void OnWidgetDestroying(Widget* widget) override; 53 void OnWidgetDestroying(Widget* widget) override;
51 void OnWidgetVisibilityChanging(Widget* widget, bool visible) override; 54 void OnWidgetVisibilityChanging(Widget* widget, bool visible) override;
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 210
208 // Parent native window of the bubble. 211 // Parent native window of the bubble.
209 gfx::NativeView parent_window_; 212 gfx::NativeView parent_window_;
210 213
211 DISALLOW_COPY_AND_ASSIGN(BubbleDialogDelegateView); 214 DISALLOW_COPY_AND_ASSIGN(BubbleDialogDelegateView);
212 }; 215 };
213 216
214 } // namespace views 217 } // namespace views
215 218
216 #endif // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE2_H_ 219 #endif // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE2_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/bubble/bubble_dialog_delegate.cc » ('j') | ui/views/bubble/bubble_dialog_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698