views: don't snap dialogs with no buttons

ui/views/bubble/bubble_dialog_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 
 #include "build/build_config.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/base/default_style.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 69 matching lines @@
   // Linux clips bubble windows that extend outside their parent window bounds.
   // Mac never adjusts.
   bubble_delegate->set_adjust_if_offscreen(false);
 #endif
 
   bubble_delegate->SizeToContents();
   bubble_widget->AddObserver(bubble_delegate);
   return bubble_widget;
 }
 
+bool BubbleDialogDelegateView::ShouldSnapFrameWidth() const {
+  return GetDialogButtons() != ui::DIALOG_BUTTON_NONE;

[Peter Kasting, 2017/05/10 20:41:24]

Why do this in BubbleDialogDelegateView rather than the parent
DialogDelegateView?

[Elly Fong-Jones, 2017/05/10 21:06:49]

Oops! It should definitely be on DialogDelegateView, fixed :)

+}
+
 BubbleDialogDelegateView* BubbleDialogDelegateView::AsBubbleDialogDelegate() {
   return this;
 }
 
 bool BubbleDialogDelegateView::ShouldShowCloseButton() const {
   return false;
 }
 
 ClientView* BubbleDialogDelegateView::CreateClientView(Widget* widget) {
   DialogClientView* client = new DialogClientView(widget, GetContentsView());
@@ skipping 220 matching lines @@
   // http://crbug.com/474622 for details.
   if (widget == GetWidget() && visible) {
     ui::AXNodeData node_data;
     GetAccessibleNodeData(&node_data);
     if (node_data.role == ui::AX_ROLE_ALERT_DIALOG)
       NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
   }
 }
 
 }  // namespace views