Issue 2880393002: More clean-up after getting common protocol classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2880393002: More clean-up after getting common protocol classes (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson

Modified:
3 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -206 lines)			Patch
M	pkg/analysis_server/lib/src/plugin/request_converter.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	pkg/analysis_server/test/src/plugin/notification_manager_test.dart	View	14 chunks	+41 lines, -41 lines	0 comments	Download
M	pkg/analysis_server/test/src/plugin/protocol_test_utilities.dart	View	6 chunks	+33 lines, -129 lines	0 comments	Download
M	pkg/analysis_server/test/src/plugin/result_converter_test.dart	View	4 chunks	+29 lines, -30 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

As far as I know, this is the last of the clean-up after making some ...

3 years, 7 months ago (2017-05-15 17:46:02 UTC) #2

Brian Wilkerson

3 years, 7 months ago (2017-05-15 20:02:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a03958bfc969a09b0a4aff22708c28735ff51c99 (presubmit successful).