Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/ui/commands/show_signin_command.mm

Issue 2880333003: Adding ChromeIdentity in ShowSigninCommand. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/commands/show_signin_command.mm
diff --git a/ios/chrome/browser/ui/commands/show_signin_command.mm b/ios/chrome/browser/ui/commands/show_signin_command.mm
index b71ec1e1b404501df21d8ba36ff6c8ec040c556f..a5ee202183311c2decacf059ab1d9adeea5ca9cf 100644
--- a/ios/chrome/browser/ui/commands/show_signin_command.mm
+++ b/ios/chrome/browser/ui/commands/show_signin_command.mm
@@ -14,6 +14,7 @@
@implementation ShowSigninCommand
@synthesize operation = _operation;
+@synthesize identity = _identity;
@synthesize accessPoint = _accessPoint;
@synthesize promoAction = _promoAction;
@synthesize callback = _callback;
@@ -24,12 +25,18 @@
}
- (instancetype)initWithOperation:(AuthenticationOperation)operation
+ identity:(ChromeIdentity*)identity
accessPoint:(signin_metrics::AccessPoint)accessPoint
promoAction:(signin_metrics::PromoAction)promoAction
callback:
(ShowSigninCommandCompletionCallback)callback {
if ((self = [super initWithTag:IDC_SHOW_SIGNIN_IOS])) {
+ DCHECK((operation == AUTHENTICATION_OPERATION_SIGNIN_PROMO_CONTINUE_AS &&
+ identity) ||
+ (operation != AUTHENTICATION_OPERATION_SIGNIN_PROMO_CONTINUE_AS &&
+ !identity));
_operation = operation;
+ _identity = identity;
_accessPoint = accessPoint;
_promoAction = promoAction;
_callback = [callback copy];
@@ -41,6 +48,7 @@
accessPoint:(signin_metrics::AccessPoint)accessPoint
promoAction:(signin_metrics::PromoAction)promoAction {
return [self initWithOperation:operation
+ identity:nil
accessPoint:accessPoint
promoAction:promoAction
callback:nil];

Powered by Google App Engine
This is Rietveld 408576698