Adding ChromeIdentity in ShowSigninCommand.

ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/metrics/user_metrics.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 188 matching lines @@
             promoAction:signin_metrics::PromoAction::PROMO_ACTION_NEW_ACCOUNT];
   [signinPromoView chromeExecuteCommand:command];
 }
 
 - (void)signinPromoViewSigninWithDefaultAccount:
     (SigninPromoView*)signinPromoView {
   DCHECK(_defaultIdentity);
   RecordSigninUserActionForAccessPoint(_accessPoint);
   RecordSigninDefaultUserActionForAccessPoint(_accessPoint);
   ShowSigninCommand* command = [[ShowSigninCommand alloc]
       initWithOperation:AUTHENTICATION_OPERATION_SIGNIN_PROMO_CONTINUE_AS

[msarda, 2017/05/16 13:33:53]

Use AUTHENTICATION_OPERATION_SIGNIN.

[jlebel, 2017/05/16 17:55:08]

Done.

+               identity:_defaultIdentity
             accessPoint:_accessPoint
-            promoAction:signin_metrics::PromoAction::PROMO_ACTION_WITH_DEFAULT];
+            promoAction:signin_metrics::PromoAction::PROMO_ACTION_WITH_DEFAULT
+               callback:nil];

[msarda, 2017/05/16 13:33:53]

Remove "callback" (it is nil by default).

[jlebel, 2017/05/16 17:55:08]

-[ShowSigninCommand initWithOperation:identity:accessPoint:promoAction:] doesn't
exist. I'm not sure it is relevant to create this method since it is used only
once.
I would prefer to keep it that way if it is ok with you.

   [signinPromoView chromeExecuteCommand:command];
 }
 
 - (void)signinPromoViewSigninWithOtherAccount:
     (SigninPromoView*)signinPromoView {
   DCHECK(_defaultIdentity);
   RecordSigninNotDefaultUserActionForAccessPoint(_accessPoint);
   RecordSigninUserActionForAccessPoint(_accessPoint);
   ShowSigninCommand* command = [[ShowSigninCommand alloc]
       initWithOperation:AUTHENTICATION_OPERATION_SIGNIN
             accessPoint:_accessPoint
             promoAction:signin_metrics::PromoAction::PROMO_ACTION_NOT_DEFAULT];
   [signinPromoView chromeExecuteCommand:command];
 }
 
 @end