Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 288033016: GN build: GPU work, Windows compile, "check" errors (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
urvang (Google), piman
CC:
chromium-reviews, urvang (Google), piman+watch_chromium.org, skal, vikasa, jzern
Base URL:
https://chromium.googlesource.com/chromium/src
Visibility:
Public.

Description

GN build: GPU work, Windows compile, "check" errors Fix the "gn check" header errors. Remove the extra "gles2_utils" target which "gn check" flags as an error. This target is actually inseparable from "command_buffer_common" but exists this way to prevent cycles in GYP files (but not GYP targets). GN doesn't have this problem, so I merged them. Moved the GPU targets out into build files closer to their files (gpu/command_buffer/client and .../common). This leaves a BUILD.gn file in gpu/ with a comment listing the forwarding locations, since that's where people will look for a BUILD.gn file first. Delete the duplicate gfx_unittests target, leave a comment for where it is in case somebody does a search for that name. Make webp compile on Windows Make ui/gfx compile on Windows. There were some duplicate symbols for ozone. I changed some of the filtering around to do += instead of exclusion. I think in these cases it's easier to follow and maintain. BUG= R=piman@chromium.org, urvang@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271080

Patch Set 1 #

Patch Set 2 : fix error #

Patch Set 3 : merge #

Patch Set 4 : missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -254 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +17 lines, -141 lines 0 comments Download
D gpu/command_buffer/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
A gpu/command_buffer/client/BUILD.gn View 1 2 3 1 chunk +119 lines, -0 lines 0 comments Download
A gpu/command_buffer/common/BUILD.gn View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 4 chunks +13 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 8 chunks +9 lines, -93 lines 0 comments Download
M ui/gfx/geometry/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 7 months ago (2014-05-16 05:55:23 UTC) #1
urvang (Google)
LGTM for WebP
6 years, 7 months ago (2014-05-16 17:58:02 UTC) #2
piman
lgtm
6 years, 7 months ago (2014-05-16 18:44:04 UTC) #3
brettw
6 years, 7 months ago (2014-05-16 19:34:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r271080.

Powered by Google App Engine
This is Rietveld 408576698