Remove Notifications Associated with an Extension When the Extension is Unchecked from the Message …

Remove Notifications Associated with an Extension When the Extension is Unchecked from the Message Center Settings

Added an observer relationship between MessageCenterImpl and
MessageCenterSettingsController so that the notification removal would occur
when a user unchecked an extension from the settings view.

BUG=304364
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272072

[dewittj, 2014-05-20 16:32:00]

impl looks good, needs some tests though.

[robliao, 2014-05-20 17:36:14]

On 2014/05/20 16:32:00, dewittj wrote:
> impl looks good, needs some tests though.

There's currently no framework for testing NotifierSettingsObserver. Where would
you like these tests since they cross major component boundaries?

[dewittj, 2014-05-20 17:37:51]

at least test the new stuff in MessageCenterImpl.  If you feel ambitious a test
in notifiersettingsobserver would be nice :)

[robliao, 2014-05-20 20:49:53]

Add Unit Test for removals.

[dewittj, 2014-05-20 20:51:23]

lgtm

[robliao, 2014-05-20 20:54:40]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:55:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robliao@chromium.org/288033014/20001

[commit-bot: I haz the power, 2014-05-21 02:25:55]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7217)

[commit-bot: I haz the power, 2014-05-21 02:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 02:43:19]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7371)

[robliao, 2014-05-21 03:51:37]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2014-05-21 03:53:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robliao@chromium.org/288033014/20001

[commit-bot: I haz the power, 2014-05-21 05:22:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7392)

[commit-bot: I haz the power, 2014-05-21 05:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 05:48:58]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7408)

[robliao, 2014-05-21 06:45:11]

Mac Fix

[robliao, 2014-05-21 06:45:15]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2014-05-21 06:45:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robliao@chromium.org/288033014/40001

[robliao, 2014-05-21 17:10:20]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2014-05-21 20:15:28]

Fix Mac Unit Test That Left Dangling Pointer

[robliao, 2014-05-21 20:15:33]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:18:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robliao@chromium.org/288033014/80001

[commit-bot: I haz the power, 2014-05-22 03:38:27]

Change committed as 272072