Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 288033011: telemetry: re-enable befamous in key_silk_cases. (Closed)

Created:
6 years, 7 months ago by ernstm
Modified:
6 years, 7 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

telemetry: re-enable befamous in key_silk_cases. The page works fine on ToT. Looks like the scrolling problem has been fixed. R=tonyg@chromium.org BUG=366371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/page_sets/key_silk_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ernstm
PTAL
6 years, 7 months ago (2014-05-15 22:43:48 UTC) #1
dtu
lgtm
6 years, 7 months ago (2014-05-15 23:17:05 UTC) #2
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 7 months ago (2014-05-15 23:37:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/288033011/1
6 years, 7 months ago (2014-05-15 23:39:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 02:12:55 UTC) #5
commit-bot: I haz the power
Change committed as 270918
6 years, 7 months ago (2014-05-16 03:26:55 UTC) #6
tonyg
On 2014/05/16 03:26:55, I haz the power (commit-bot) wrote: > Change committed as 270918 We ...
6 years, 7 months ago (2014-05-16 09:19:10 UTC) #7
ernstm
6 years, 7 months ago (2014-05-16 20:27:40 UTC) #8
Message was sent while issue was closed.
On 2014/05/16 09:19:10, tonyg wrote:
> On 2014/05/16 03:26:55, I haz the power (commit-bot) wrote:
> > Change committed as 270918
> 
> We probably should have added a unittest of some sort that would have caught
the
> failure that triggered this to be disabled.  Perhaps something for a
follow-up?

The page didn't scroll. It is not possible to detect that in all cases:
https://code.google.com/p/chromium/issues/detail?id=360204#c7

Powered by Google App Engine
This is Rietveld 408576698