Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/upgrade_detector.cc

Issue 288033005: Remove resources that no one is using (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector.cc
diff --git a/chrome/browser/upgrade_detector.cc b/chrome/browser/upgrade_detector.cc
index 55327bd18485316ea8454d51db0968da1b11e4b2..79e062351535b0f08ad751cf2ca7e08fee547c47 100644
--- a/chrome/browser/upgrade_detector.cc
+++ b/chrome/browser/upgrade_detector.cc
@@ -40,23 +40,7 @@ void UpgradeDetector::RegisterPrefs(PrefRegistrySimple* registry) {
int UpgradeDetector::GetIconResourceID(UpgradeNotificationIconType type) {
if (type == UPGRADE_ICON_TYPE_BADGE) {
oshima 2014/05/15 18:23:19 I'll remove enum in separate CL.
- // Badges do not exist on Views and Mac OS X.
-#if !defined(TOOLKIT_VIEWS) && !defined(OS_MACOSX)
- switch (upgrade_notification_stage_) {
- case UPGRADE_ANNOYANCE_NONE:
- return 0;
- case UPGRADE_ANNOYANCE_LOW:
- return IDR_UPDATE_BADGE;
- case UPGRADE_ANNOYANCE_ELEVATED:
- return IDR_UPDATE_BADGE2;
- case UPGRADE_ANNOYANCE_HIGH:
- return IDR_UPDATE_BADGE3;
- case UPGRADE_ANNOYANCE_SEVERE:
- return IDR_UPDATE_BADGE3;
- case UPGRADE_ANNOYANCE_CRITICAL:
- return IDR_UPDATE_BADGE3;
- }
-#endif
+ // TODO(oshima): Badges no longer exist. remove this.
NOTREACHED();
return 0;
}
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698