Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 288033005: Remove resources that no one is using (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, sky, newt (away)
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Remove resources for "not toolkit_views and not is_macosx and not is_ios". This matches android, but android is not using them (I believe). This seems to be left-over from linux_gtk configuration, which has been removed. I'll remove png files in separate CL. BUG=373482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271176

Patch Set 1 : #

Total comments: 1

Patch Set 2 : more resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -93 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 13 chunks +0 lines, -76 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 chunk +1 line, -17 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
jhawkins -> upgrade_cetector.cc newt -> please confirm this is ok from android perspective. https://codereview.chromium.org/288033005/diff/20001/chrome/browser/upgrade_detector.cc File ...
6 years, 7 months ago (2014-05-15 18:23:19 UTC) #1
newt (away)
These aren't used by Android. Thanks for checking!
6 years, 7 months ago (2014-05-15 18:31:45 UTC) #2
oshima
On 2014/05/15 18:31:45, newt wrote: > These aren't used by Android. Thanks for checking! so ...
6 years, 7 months ago (2014-05-15 18:59:14 UTC) #3
newt (away)
On 2014/05/15 18:59:14, oshima wrote: > On 2014/05/15 18:31:45, newt wrote: > > These aren't ...
6 years, 7 months ago (2014-05-15 20:23:02 UTC) #4
oshima
Lei, can you approve the change in upgrade_detector.cc ?
6 years, 7 months ago (2014-05-16 03:56:03 UTC) #5
sky
LGTM
6 years, 7 months ago (2014-05-16 20:35:11 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-16 20:35:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/288033005/30001
6 years, 7 months ago (2014-05-16 20:36:41 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 05:24:48 UTC) #9
Message was sent while issue was closed.
Change committed as 271176

Powered by Google App Engine
This is Rietveld 408576698