chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h - Issue 2880323003: Various cleaups for AMP page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 2880323003: Various cleaups for AMP page load metrics. (Closed)

Patch Set: improve tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

index 8dbe8ee98b5816c0ad5922a5d28e8283abeeae83..3033394528ce83644606f812db52860a562e4399 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

@@ -95,7 +95,7 @@ class FromGWSPageLoadMetricsLogger {

const page_load_metrics::PageLoadExtraInfo& extra_info);

// The methods below are public only for testing.

- static bool IsGoogleSearchHostname(base::StringPiece host);

+ static bool IsGoogleSearchHostname(const GURL& url);

static bool IsGoogleSearchResultUrl(const GURL& url);

static bool IsGoogleSearchRedirectorUrl(const GURL& url);

bool ShouldLogFailedProvisionalLoadMetrics();