Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

Issue 2880323003: Various cleaups for AMP page load metrics. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
index 299b3ae3b8963b9772383084076b886cc34ec4e8..3b590ab2680e96b1e24dfa12637dc4b883140ca3 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
@@ -712,21 +712,22 @@ TEST_F(FromGWSPageLoadMetricsLoggerTest, IsGoogleSearchHostname) {
bool expected_result;
const char* url;
} test_cases[] = {
- {true, "www.google.com"},
- {true, "www.google.co.uk"},
- {true, "www.google.co.in"},
- {false, "other.google.com"},
- {false, "other.www.google.com"},
- {false, "www.other.google.com"},
- {false, "www.www.google.com"},
- {false, "www.google.appspot.com"},
- {false, "www.google.example.com"},
+ {true, "https://www.google.com/"},
+ {true, "https://www.google.co.uk/"},
+ {true, "https://www.google.co.in/"},
+ {false, "https://other.google.com/"},
+ {false, "https://other.www.google.com/"},
+ {false, "https://www.other.google.com/"},
+ {false, "https://www.www.google.com/"},
+ {false, "https://www.google.appspot.com/"},
+ {false, "https://www.google.example.com/"},
// Search results are not served from the bare google.com domain.
- {false, "google.com"},
+ {false, "https://google.com/"},
};
for (const auto& test : test_cases) {
- EXPECT_EQ(test.expected_result,
- FromGWSPageLoadMetricsLogger::IsGoogleSearchHostname(test.url))
+ EXPECT_EQ(
+ test.expected_result,
+ FromGWSPageLoadMetricsLogger::IsGoogleSearchHostname(GURL(test.url)))
<< "for URL: " << test.url;
}
}

Powered by Google App Engine
This is Rietveld 408576698