Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h

Issue 2880323003: Various cleaups for AMP page load metrics. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
index 93941a2ad004e00845de6595972ecb6335ebaed7..5225b74c36330392bceb7d30ba5b39b4dec659af 100644
--- a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
@@ -26,6 +26,15 @@ struct PageLoadTiming;
class AMPPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
+ enum class AMPViewType {
+ NONE,
+ AMP_CACHE,
+ GOOGLE_SEARCH_AMP_VIEWER,
+ GOOGLE_NEWS_AMP_VIEWER,
+ };
+
+ static AMPViewType GetAMPViewType(const GURL& url);
+
AMPPageLoadMetricsObserver();
~AMPPageLoadMetricsObserver() override;
@@ -46,6 +55,8 @@ class AMPPageLoadMetricsObserver
const page_load_metrics::PageLoadExtraInfo& info) override;
private:
+ AMPViewType view_type_ = AMPViewType::NONE;
+
DISALLOW_COPY_AND_ASSIGN(AMPPageLoadMetricsObserver);
};
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698