Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/ui/libgtkui/BUILD.gn

Issue 2880223002: Reland: Compile FreeType with HarfBuzz support (Closed)
Patch Set: Fix Android build, and update TestExpectations for linux rebaselines Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/freetype/freetype.gni ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_linux, "This file should only be referenced on Linux") 5 assert(is_linux, "This file should only be referenced on Linux")
6 6
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/linux/gtk/gtk.gni") 8 import("//build/config/linux/gtk/gtk.gni")
9 import("//printing/features/features.gni") 9 import("//printing/features/features.gni")
10 10
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 ] 92 ]
93 configs += [ "//build/config/linux/gconf" ] 93 configs += [ "//build/config/linux/gconf" ]
94 } 94 }
95 95
96 if (use_cups) { 96 if (use_cups) {
97 configs += [ "//printing:cups" ] 97 configs += [ "//printing:cups" ]
98 } 98 }
99 99
100 defines = [ "LIBGTKUI_IMPLEMENTATION" ] 100 defines = [ "LIBGTKUI_IMPLEMENTATION" ]
101 101
102 # GTK pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz.
103 # To avoid missing indirectly referenced harfbuzz symbols from pango,
104 # some hack is required when bundled harfbuzz is used and component build is
105 # disabled.
106 # See crbug.com/462689 for details.
107 all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
108
109 deps = invoker.deps + [ 102 deps = invoker.deps + [
110 "//base", 103 "//base",
111 "//base:i18n", 104 "//base:i18n",
112 "//base/third_party/dynamic_annotations", 105 "//base/third_party/dynamic_annotations",
113 "//cc/paint", 106 "//cc/paint",
114 "//chrome:extra_resources", 107 "//chrome:extra_resources",
115 "//chrome:resources", 108 "//chrome:resources",
116 "//chrome:strings", 109 "//chrome:strings",
117 "//chrome/app:command_ids", 110 "//chrome/app:command_ids",
118 "//chrome/app/theme:theme_resources", 111 "//chrome/app/theme:theme_resources",
119 "//components/resources", 112 "//components/resources",
120 "//content/public/browser", 113 "//content/public/browser",
121 "//printing", 114 "//printing",
122 "//skia", 115 "//skia",
116
117 # GTK pulls pangoft2, which requires HarfBuzz symbols. Since we
118 # link our own HarfBuzz, avoid mixing symbols from system HarfBuzz
119 # and own ones, hence the dependency to harfbuzz-ng here.
120 "//third_party/harfbuzz-ng",
Evan Stade 2017/05/15 16:40:07 this looks like something thomasanderson@ knows ab
123 "//ui/aura", 121 "//ui/aura",
124 "//ui/base", 122 "//ui/base",
125 "//ui/base/ime", 123 "//ui/base/ime",
126 "//ui/display", 124 "//ui/display",
127 "//ui/events", 125 "//ui/events",
128 "//ui/events:events_base", 126 "//ui/events:events_base",
129 "//ui/events/platform/x11", 127 "//ui/events/platform/x11",
130 "//ui/gfx", 128 "//ui/gfx",
131 "//ui/gfx/geometry", 129 "//ui/gfx/geometry",
132 "//ui/gfx/x", 130 "//ui/gfx/x",
(...skipping 25 matching lines...) Expand all
158 sources = [ 156 sources = [
159 "native_theme_gtk2.cc", 157 "native_theme_gtk2.cc",
160 "native_theme_gtk2.h", 158 "native_theme_gtk2.h",
161 ] 159 ]
162 deps = [ 160 deps = [
163 "//build/config/linux/gtk2", 161 "//build/config/linux/gtk2",
164 "//build/config/linux/gtk2:gtkprint2", 162 "//build/config/linux/gtk2:gtkprint2",
165 ] 163 ]
166 } 164 }
167 } 165 }
OLDNEW
« no previous file with comments | « build/config/freetype/freetype.gni ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698