Re-apply status file parser changes from 0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c.

Re-apply status file parser changes from 0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/a881aed3548abec9e7eeeca23cb89d28835aa06b

[Bob Nystrom, 2017-05-16 01:53:28]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bob Nystrom, 2017-05-16 01:53:29]

My status file changes did, unfortunately change the behavior.

I'm not sure how I didn't catch this on my testing, but the expression evaluator
was broken. This fixes that. The second patch has the only difference from the
first time I landed this.

[Bill Hesse, 2017-05-16 09:42:50]

LGTM with comment.

https://codereview.chromium.org/2880203004/diff/20001/tools/testing/dart/stat...
File tools/testing/dart/status_expression.dart (right):

https://codereview.chromium.org/2880203004/diff/20001/tools/testing/dart/stat...
tools/testing/dart/status_expression.dart:74: /// should be Boolean and the
expression is true when the value is `true`.
I looked at this code, and was most worried about how expressions like

$checked == false
or 
$checked != true
would work.  There is no other way to express that a boolean variable is false,
and we have lines like both of these examples in the status files.

I'm not convinced these will work, if == 'true' didn't work here.  Maybe we have
to check the identifier for 'true' or 'false' and compare to the boolean in that
case, in the implementation of == and !=.

[Bob Nystrom, 2017-05-17 20:03:59]

https://codereview.chromium.org/2880203004/diff/20001/tools/testing/dart/stat...
File tools/testing/dart/status_expression.dart (right):

https://codereview.chromium.org/2880203004/diff/20001/tools/testing/dart/stat...
tools/testing/dart/status_expression.dart:74: /// should be Boolean and the
expression is true when the value is `true`.
On 2017/05/16 09:42:50, Bill Hesse wrote:
> I looked at this code, and was most worried about how expressions like
> 
> $checked == false
> or 
> $checked != true
> would work.  There is no other way to express that a boolean variable is
false,
> and we have lines like both of these examples in the status files.
> 
> I'm not convinced these will work, if == 'true' didn't work here.  Maybe we
have
> to check the identifier for 'true' or 'false' and compare to the boolean in
that
> case, in the implementation of == and !=.

Yeah, I think you're right. I was hoping to do something less stringly typed,
but since we don't have real boolean literals in status expressions, just the
literal strings "true" and "false", it's better to stringify everything.

[Bob Nystrom, 2017-05-17 20:04:38]

Description was changed from

==========
Re-apply status file parser changes from
0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c.
==========

to

==========
Re-apply status file parser changes from
0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a881aed3548abec9e7eeeca23cb89d28835aa06b
==========

[Bob Nystrom, 2017-05-17 20:04:39]

Committed patchset #3 (id:40001) manually as
a881aed3548abec9e7eeeca23cb89d28835aa06b (presubmit successful).