PaymentHandler: Should not allow accessing PaymentManager in Extension.

third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentAppServiceWorkerRegistration.h"
 
+#include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
+#include "core/dom/ExecutionContext.h"
 #include "modules/payments/PaymentManager.h"
 #include "modules/serviceworkers/ServiceWorkerRegistration.h"
 #include "platform/bindings/ScriptState.h"
+#include "platform/weborigin/KURL.h"
+#include "platform/weborigin/SecurityOrigin.h"
 
 namespace blink {
 
 PaymentAppServiceWorkerRegistration::~PaymentAppServiceWorkerRegistration() {}
 
 // static
 PaymentAppServiceWorkerRegistration& PaymentAppServiceWorkerRegistration::From(
     ServiceWorkerRegistration& registration) {
   PaymentAppServiceWorkerRegistration* supplement =
       static_cast<PaymentAppServiceWorkerRegistration*>(
           Supplement<ServiceWorkerRegistration>::From(registration,
                                                       SupplementName()));
 
   if (!supplement) {
     supplement = new PaymentAppServiceWorkerRegistration(&registration);
     ProvideTo(registration, SupplementName(), supplement);
   }
 
   return *supplement;
 }
 
 // static
 PaymentManager* PaymentAppServiceWorkerRegistration::paymentManager(
     ScriptState* script_state,
-    ServiceWorkerRegistration& registration) {
+    ServiceWorkerRegistration& registration,
+    ExceptionState& exception_state) {
   return PaymentAppServiceWorkerRegistration::From(registration)
-      .paymentManager(script_state);
+      .paymentManager(script_state, exception_state);
 }
 
 PaymentManager* PaymentAppServiceWorkerRegistration::paymentManager(
-    ScriptState* script_state) {
+    ScriptState* script_state,
+    ExceptionState& exception_state) {
+  ExecutionContext* context = ExecutionContext::From(script_state);
+  KURL origin = KURL(KURL(), context->GetSecurityOrigin()->ToString());
+  if (!origin.ProtocolIsInHTTPFamily()) {

[please use gerrit instead, 2017/05/15 14:46:47]

Also check context->IsSecureContext().

[zino, 2017/05/15 18:38:12]

I don't think this check is needed.
because the ServiceWorkerRegistration is already enabled in SecureContext only.
On the other hand, "chrome-extension://" scheme is treated as a secure context.
So, we need to check whether this is https or not.
Instead I left a comment here. WDYT?

+    exception_state.ThrowSecurityError(
+        "The PaymentManger attirbute is only allowed in https://* context.");

[please use gerrit instead, 2017/05/15 14:46:47]

PaymentManger can be used only in HTTPS scheme.

[zino, 2017/05/15 18:38:12]

Done.

+    return nullptr;
+  }
+
   if (!payment_manager_) {
     payment_manager_ = PaymentManager::Create(registration_);
   }
   return payment_manager_.Get();
 }
 
 DEFINE_TRACE(PaymentAppServiceWorkerRegistration) {
   visitor->Trace(registration_);
   visitor->Trace(payment_manager_);
   Supplement<ServiceWorkerRegistration>::Trace(visitor);
 }
 
 PaymentAppServiceWorkerRegistration::PaymentAppServiceWorkerRegistration(
     ServiceWorkerRegistration* registration)
     : registration_(registration) {}
 
 // static
 const char* PaymentAppServiceWorkerRegistration::SupplementName() {
   return "PaymentAppServiceWorkerRegistration";
 }
 
 }  // namespace blink