Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/gn/command_desc.cc

Issue 2880093002: gn desc: printing public_deps without --all and --tree
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/desc_builder.cc » ('j') | tools/gn/target.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index 8dbe6de7de932ec9b67c7cf2219cc6acbf6b8293..58c835320d1020171c6009df70cefedfba00de7b 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -372,8 +372,14 @@ Printing outputs
Printing deps
- Deps will include all public, private, and data deps (TODO this could be
- clarified and enhanced) sorted in order applying. The following may be used:
+ Deps could include public, private and data deps.
+
+ If the command is invoked with --tree or --all, deps will include all public,
brettw 2017/05/23 17:23:05 Documentation formatting: Can you wrap this togeth
mbonadei1 2017/05/26 09:29:44 Done.
+ private and data deps.
+ If the command is invoked without --tree and --all deps will only include
+ private and data deps. In this case public deps will be printed as part of
brettw 2017/05/23 17:23:05 This says "deps" will include data deps, is that r
mbonadei1 2017/05/26 09:29:44 I am not sure I am following, let me try to rephra
+ the section "public_deps".
+ Deps will be sorted in order applying. The following may be used:
--all
Collects all recursive dependencies and prints a sorted flat list. Also
« no previous file with comments | « no previous file | tools/gn/desc_builder.cc » ('j') | tools/gn/target.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698