Tiny refactor of HttpStreamFactoryImpl::Job::Orphan to simplify the code.

Tiny refactor of HttpStreamFactoryImpl::Job::Orphan to simplify the code.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270882

[Ryan Hamilton, 2014-05-15 18:06:08]

This is a tiny change... Hopefully it'll be a fast review :>

[mmenke, 2014-05-15 18:30:21]

https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
net/http/http_stream_factory_impl_job.cc:219: blocking_job_ = NULL;
We're no longer calling OnOrphanedJobComplete in the case there was a
blocking_job_ but this isn't a websockets request?  Is that deliberate?

[Ryan Hamilton, 2014-05-15 18:47:38]

https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
net/http/http_stream_factory_impl_job.cc:219: blocking_job_ = NULL;
On 2014/05/15 18:30:21, mmenke wrote:
> We're no longer calling OnOrphanedJobComplete in the case there was a
> blocking_job_ but this isn't a websockets request?  Is that deliberate?

ARGH! No, this was *not* intentional. I misread the initial code because of the
lack of {}s. Ok, I've reverted the change, but added {}s so the next reader is
not confused.

Thanks for catching this. (Annoyingly, no tests failed)

[mmenke, 2014-05-15 18:52:29]

On 2014/05/15 18:47:38, Ryan Hamilton wrote:
>
https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
> File net/http/http_stream_factory_impl_job.cc (right):
> 
>
https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
> net/http/http_stream_factory_impl_job.cc:219: blocking_job_ = NULL;
> On 2014/05/15 18:30:21, mmenke wrote:
> > We're no longer calling OnOrphanedJobComplete in the case there was a
> > blocking_job_ but this isn't a websockets request?  Is that deliberate?
> 
> ARGH! No, this was *not* intentional. I misread the initial code because of
the
> lack of {}s. Ok, I've reverted the change, but added {}s so the next reader is
> not confused.
> 
> Thanks for catching this. (Annoyingly, no tests failed)

LGTM.

Hrm...  I don't think we normally create backup jobs, which may explain the
failures (Only for SPDY over HTTP, maybe?)

[mmenke, 2014-05-15 18:52:57]

On 2014/05/15 18:52:29, mmenke wrote:
> On 2014/05/15 18:47:38, Ryan Hamilton wrote:
> >
>
https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
> > File net/http/http_stream_factory_impl_job.cc (right):
> > 
> >
>
https://codereview.chromium.org/288003006/diff/1/net/http/http_stream_factory...
> > net/http/http_stream_factory_impl_job.cc:219: blocking_job_ = NULL;
> > On 2014/05/15 18:30:21, mmenke wrote:
> > > We're no longer calling OnOrphanedJobComplete in the case there was a
> > > blocking_job_ but this isn't a websockets request?  Is that deliberate?
> > 
> > ARGH! No, this was *not* intentional. I misread the initial code because of
> the
> > lack of {}s. Ok, I've reverted the change, but added {}s so the next reader
is
> > not confused.
> > 
> > Thanks for catching this. (Annoyingly, no tests failed)
> 
> LGTM.
> 
> Hrm...  I don't think we normally create backup jobs, which may explain the
> failures (Only for SPDY over HTTP, maybe?)

"The failure to have a failure" rather

[Ryan Hamilton, 2014-05-15 18:56:31]

On 2014/05/15 18:52:29, mmenke wrote:
> LGTM.
> 
> Hrm...  I don't think we normally create backup jobs, which may explain the
> failures (Only for SPDY over HTTP, maybe?)

*nod*

[Ryan Hamilton, 2014-05-15 18:56:34]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-05-15 18:57:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/288003006/20001

[commit-bot: I haz the power, 2014-05-15 22:38:37]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-16 00:58:16]

Change committed as 270882