Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: build/common.gypi

Issue 288003004: provide a build time flag to enable connecting to production wallet servers by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hinge on buildtype instead of branding Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/content/browser/wallet/wallet_service_url.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 6d076bb8b86f9b8c6608af84416c7056de663c21..348d5098575f7f6cb77f78c62cb6954f669da435 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -473,6 +473,10 @@
# Enables autofill dialog and associated features; disabled by default.
'enable_autofill_dialog%' : 0,
+ # Defaults Wallet integration in Autofill dialog to use production
+ # servers. Unofficial builds won't have the proper API keys.
+ 'enable_prod_wallet_service%': 0,
+
# Enables support for background apps.
'enable_background%': 1,
@@ -698,7 +702,13 @@
# Enable autofill dialog for Android, Mac and Views-enabled platforms.
['toolkit_views==1 or (OS=="android" and android_webview_build==0) or OS=="mac"', {
- 'enable_autofill_dialog%': 1
+ 'enable_autofill_dialog%': 1,
+
+ 'conditions': [
+ ['buildtype=="Official"', {
+ 'enable_prod_wallet_service%': 1,
+ }],
+ ]
}],
['OS=="android"', {
@@ -1040,6 +1050,7 @@
'enable_session_service%': '<(enable_session_service)',
'enable_themes%': '<(enable_themes)',
'enable_autofill_dialog%': '<(enable_autofill_dialog)',
+ 'enable_prod_wallet_service%': '<(enable_prod_wallet_service)',
'enable_background%': '<(enable_background)',
'linux_use_bundled_gold%': '<(linux_use_bundled_gold)',
'linux_use_bundled_binutils%': '<(linux_use_bundled_binutils)',
@@ -2595,6 +2606,9 @@
['enable_autofill_dialog==1', {
'defines': ['ENABLE_AUTOFILL_DIALOG=1'],
}],
+ ['enable_prod_wallet_service==1', {
+ 'defines': ['ENABLE_PROD_WALLET_SERVICE=1'],
+ }],
['enable_background==1', {
'defines': ['ENABLE_BACKGROUND=1'],
}],
« no previous file with comments | « no previous file | components/autofill/content/browser/wallet/wallet_service_url.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698