Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 288003002: aw: Avoid leaking GL error across android and chromium (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Avoid leaking GL error across android and chromium BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270871

Patch Set 1 #

Total comments: 1

Patch Set 2 : clear stack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M android_webview/browser/scoped_app_gl_state_restore.cc View 1 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
6 years, 7 months ago (2014-05-14 21:16:59 UTC) #1
no sievers
https://codereview.chromium.org/288003002/diff/1/android_webview/browser/scoped_app_gl_state_restore.cc File android_webview/browser/scoped_app_gl_state_restore.cc (right): https://codereview.chromium.org/288003002/diff/1/android_webview/browser/scoped_app_gl_state_restore.cc#newcode154 android_webview/browser/scoped_app_gl_state_restore.cc:154: << "Incoming GLError " << error; Since it's an ...
6 years, 7 months ago (2014-05-15 20:49:23 UTC) #2
boliu
Huh, didn't know it was a stack. While loop it is then.
6 years, 7 months ago (2014-05-15 21:26:56 UTC) #3
no sievers
lgtm
6 years, 7 months ago (2014-05-15 21:36:03 UTC) #4
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-05-15 21:36:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/288003002/20001
6 years, 7 months ago (2014-05-15 21:37:07 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 00:16:28 UTC) #7
Message was sent while issue was closed.
Change committed as 270871

Powered by Google App Engine
This is Rietveld 408576698