cc/surfaces/surface_dependency_tracker.cc - Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_dependency_tracker.cc

Issue 2880023002: cc::SurfaceDependencyTracker should not crash when a Display goes away (Closed)

Patch Set: StrictMock => NiceMock Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/surface_dependency_tracker.cc

diff --git a/cc/surfaces/surface_dependency_tracker.cc b/cc/surfaces/surface_dependency_tracker.cc

index 652ecfe731b3d97edb77d43b00664451f00da6bf..3b37d6ca2470f0e783af162c750e159cf6783c4d 100644

--- a/cc/surfaces/surface_dependency_tracker.cc

+++ b/cc/surfaces/surface_dependency_tracker.cc

@@ -49,8 +49,7 @@ void SurfaceDependencyTracker::RequestSurfaceResolution(Surface* surface) {

surface->surface_id());

}

- if (!blocked_surfaces_by_id_.count(surface->surface_id()))

- blocked_surfaces_by_id_.insert(surface->surface_id());

+ blocked_surfaces_by_id_.insert(surface->surface_id());

if (needs_deadline && !frames_since_deadline_set_)

frames_since_deadline_set_ = 0;