third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js - Issue 2879943003: DevTools: render product badges behind the setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

Issue 2879943003: DevTools: render product badges behind the setting. (Closed)

Patch Set: removed module from the list. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/product_registry/popup.css ('k') | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

diff --git a/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js b/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

index f693daf0e309d2772010e66dd7eafd60daf63555..e6bcbbd92f255321d3b87d9ad9243f8c8c53c05a 100644

--- a/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

+++ b/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

@@ -27,7 +27,7 @@ ProductRegistryImpl.Registry = class {

* @return {?ProductRegistry.Registry.ProductEntry}

entryForUrl(parsedUrl) {

- if (parsedUrl.isDataURL())

+ if (parsedUrl.isDataURL() || !parsedUrl.isValid)

return null;

// TODO(allada) This should be expanded to allow paths as as well as domain to find a product.

var productsByDomainHash = ProductRegistryImpl._productsByDomainHash;