third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js - Issue 2879943003: DevTools: render product badges behind the setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Issue 2879943003: DevTools: render product badges behind the setting. (Closed)

Patch Set: removed module from the list. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

index fd29015ba3c65e16bf3e016ae67aee8b724fe8bb..4a76e3bd7ddd69e454a7eb57ae3ce57478f990eb 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

@@ -282,7 +282,7 @@ Network.RequestTimingView = class extends UI.VBox {

* @param {number} right

function addTiming(serverTiming, right) {

- var colorGenerator = new PerfUI.FlameChart.ColorGenerator({min: 0, max: 360, count: 36}, {min: 50, max: 80}, 80);

+ var colorGenerator = new Common.Color.Generator({min: 0, max: 360, count: 36}, {min: 50, max: 80}, 80);

var isTotal = serverTiming.metric.toLowerCase() === 'total';

var tr = tableElement.createChild('tr', isTotal ? 'network-timing-footer' : '');

var metric = tr.createChild('td', 'network-timing-metric');