[Android WebView] Implement Ubercomp for Render Thread support

android_webview/browser/shared_renderer_state.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/shared_renderer_state.h"
 
 #include "android_webview/browser/browser_view_renderer_client.h"
 #include "base/bind.h"
 #include "base/location.h"
 
 namespace android_webview {
 
-DrawGLInput::DrawGLInput() : frame_id(0), width(0), height(0) {}
+DrawGLInput::DrawGLInput() : width(0), height(0) {
+}
 
-DrawGLResult::DrawGLResult() : frame_id(0), clip_contains_visible_rect(false) {}
+DrawGLInput::~DrawGLInput() {
+}
+
+DrawGLResult::DrawGLResult() : clip_contains_visible_rect(false) {
+}
 
 SharedRendererState::SharedRendererState(
     scoped_refptr<base::MessageLoopProxy> ui_loop,
     BrowserViewRendererClient* client)
     : ui_loop_(ui_loop),
       client_on_ui_(client),
       weak_factory_on_ui_thread_(this),
       ui_thread_weak_ptr_(weak_factory_on_ui_thread_.GetWeakPtr()),
       compositor_(NULL),
       memory_policy_dirty_(false),
-      hardware_initialized_(false) {
+      hardware_initialized_(false),
+      share_context_(NULL) {
   DCHECK(ui_loop_->BelongsToCurrentThread());
   DCHECK(client_on_ui_);
 }
 
 SharedRendererState::~SharedRendererState() {}
 
 void SharedRendererState::ClientRequestDrawGL() {
   if (ui_loop_->BelongsToCurrentThread()) {

[no sievers, 2014/05/20 20:48:26]

Does this request a draw on the UI or RenderThread?

[boliu, 2014/05/21 01:33:26]

The ClientRequestDrawGLOnUIThread call has to happen on UI thread. But it
requests draw on whatever the framework GL thread is (ie RT).

     ClientRequestDrawGLOnUIThread();
   } else {
     ui_loop_->PostTask(
         FROM_HERE,
         base::Bind(&SharedRendererState::ClientRequestDrawGLOnUIThread,
                    ui_thread_weak_ptr_));
   }
 }
 
 void SharedRendererState::ClientRequestDrawGLOnUIThread() {
@@ skipping 24 matching lines @@
     memory_policy_dirty_ = true;
   }
 }
 
 content::SynchronousCompositorMemoryPolicy
 SharedRendererState::GetMemoryPolicy() const {
   base::AutoLock lock(lock_);
   return memory_policy_;
 }
 
-void SharedRendererState::SetDrawGLInput(const DrawGLInput& input) {
+void SharedRendererState::SetDrawGLInput(scoped_ptr<DrawGLInput> input) {
   base::AutoLock lock(lock_);
-  draw_gl_input_ = input;
+  DCHECK(!draw_gl_input_.get());
+  draw_gl_input_ = input.Pass();
 }
 
-DrawGLInput SharedRendererState::GetDrawGLInput() const {
+scoped_ptr<DrawGLInput> SharedRendererState::PassDrawGLInput() {
   base::AutoLock lock(lock_);
-  return draw_gl_input_;
+  return draw_gl_input_.Pass();
 }
 
 void SharedRendererState::ClearClosureQueue() {
   base::AutoLock lock(lock_);
   std::queue<base::Closure> empty;
   std::swap(closure_queue_, empty);
 }
 
 void SharedRendererState::AppendClosure(const base::Closure& closure) {
   base::AutoLock lock(lock_);
@@ skipping 15 matching lines @@
 void SharedRendererState::SetHardwareInitialized(bool initialized) {
   base::AutoLock lock(lock_);
   hardware_initialized_ = initialized;
 }
 
 bool SharedRendererState::IsHardwareInitialized() const {
   base::AutoLock lock(lock_);
   return hardware_initialized_;
 }
 
+void SharedRendererState::SetSharedContext(gpu::GLInProcessContext* context) {
+  DCHECK(!share_context_ || !context);
+  share_context_ = context;

[no sievers, 2014/05/20 20:48:26]

This looks like it might not be thread-safe. Set/Get happen across Render and UI
thread, no?

[boliu, 2014/05/21 01:33:26]

Ehh...that's because I forgot the lock :p

Fixed.

Technically, this actually should be safe since Setter is called before
requesting for DrawGL, but don't need to make this hard-to-test assumption.

+}
+
+gpu::GLInProcessContext* SharedRendererState::GetSharedContext() const {
+  DCHECK(share_context_);
+  return share_context_;
+}
+
 void SharedRendererState::SetMemoryPolicyDirty(bool is_dirty) {
   base::AutoLock lock(lock_);
   memory_policy_dirty_ = is_dirty;
 }
 
 bool SharedRendererState::IsMemoryPolicyDirty() const {
   base::AutoLock lock(lock_);
   return memory_policy_dirty_;
 }
 
+void SharedRendererState::ReturnResources(
+    const cc::TransferableResourceArray& input) {
+  base::AutoLock lock(lock_);
+  cc::TransferableResource::ReturnResources(input, &returned_resources_);
+}
+
+void SharedRendererState::InsertReturnedResources(
+    const cc::ReturnedResourceArray& resources) {
+  base::AutoLock lock(lock_);
+  returned_resources_.insert(
+      returned_resources_.end(), resources.begin(), resources.end());
+}
+
+void SharedRendererState::SwapReturnedResources(
+    cc::ReturnedResourceArray* resources) {
+  base::AutoLock lock(lock_);
+  resources->swap(returned_resources_);
+}
+
+bool SharedRendererState::ReturnedResourcesEmpty() const {
+  base::AutoLock lock(lock_);
+  return returned_resources_.empty();
+}
+
 }  // namespace android_webview