Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2879923003: [inspector] added targetCallFrames for continueToLocation (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-debugger-agent-impl.h
diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h
index 9f3d90a69d60863715e5e73ced939ced08185ca1..888648576c62912adbc5fbbc7a6b2b06b1187faf 100644
--- a/src/inspector/v8-debugger-agent-impl.h
+++ b/src/inspector/v8-debugger-agent-impl.h
@@ -23,6 +23,7 @@ class V8DebuggerScript;
class V8InspectorImpl;
class V8InspectorSessionImpl;
class V8Regex;
+class V8StackTraceImpl;
using protocol::Maybe;
using protocol::Response;
@@ -56,8 +57,8 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
Maybe<String16> optionalCondition, String16*,
std::unique_ptr<protocol::Debugger::Location>* actualLocation) override;
Response removeBreakpoint(const String16& breakpointId) override;
- Response continueToLocation(
- std::unique_ptr<protocol::Debugger::Location>) override;
+ Response continueToLocation(std::unique_ptr<protocol::Debugger::Location>,
+ Maybe<String16> strategy) override;
Response searchInContent(
const String16& scriptId, const String16& query,
Maybe<bool> optionalCaseSensitive, Maybe<bool> optionalIsRegex,
@@ -139,6 +140,7 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
const v8::debug::Location& end);
bool skipAllPauses() const { return m_skipAllPauses; }
+ bool shouldIgnoreContinueToLocation(const String16& breakpointId);
dgozman 2017/05/15 17:01:26 This should reside in V8Debugger. It's very simila
kozy 2017/05/16 01:43:48 Done in separate CL.
v8::Isolate* isolate() { return m_isolate; }
@@ -156,6 +158,7 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
const String16& hint);
void removeBreakpointImpl(const String16& breakpointId);
void clearBreakDetails();
+ void clearContinueToLocation();
void internalSetAsyncCallStackDepth(int);
void increaseCachedSkipStackGeneration();
@@ -185,6 +188,8 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
BreakpointIdToDebuggerBreakpointIdsMap m_breakpointIdToDebuggerBreakpointIds;
DebugServerBreakpointToBreakpointIdAndSourceMap m_serverBreakpoints;
String16 m_continueToLocationBreakpointId;
+ String16 m_continueToLocationStrategy;
+ std::unique_ptr<V8StackTraceImpl> m_continueToLocationStack;
using BreakReason =
std::pair<String16, std::unique_ptr<protocol::DictionaryValue>>;

Powered by Google App Engine
This is Rietveld 408576698