Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2879843004: Add progress events for loading DDC summaries to make it clear to users whether loading a DDC appli… (Closed)

Created:
3 years, 7 months ago by Jacob
Modified:
3 years, 7 months ago
Reviewers:
Alan Knight
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add progress events for loading DDC summaries to make it clear to users whether loading a DDC application has timed out. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/65e0b8994e0d0b930e1b43e54aa12520ea0c5e2d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add progress events for loading DDC summaries to make it clear to users whether loading a DDC appli… #

Patch Set 3 : Add ignoreAllErrors option to dart:_runtime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 2 chunks +20 lines, -5 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 7 months ago (2017-05-13 00:12:44 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/2879843004/diff/1/pkg/dev_compiler/web/web_command.dart File pkg/dev_compiler/web/web_command.dart (right): https://codereview.chromium.org/2879843004/diff/1/pkg/dev_compiler/web/web_command.dart#newcode118 pkg/dev_compiler/web/web_command.dart:118: var ret = await HttpRequest.request(summaryUrl, Style guide frowns ...
3 years, 7 months ago (2017-05-13 00:22:41 UTC) #3
Jacob
On 2017/05/13 00:22:41, Alan Knight wrote: > lgtm > > https://codereview.chromium.org/2879843004/diff/1/pkg/dev_compiler/web/web_command.dart > File pkg/dev_compiler/web/web_command.dart (right): ...
3 years, 7 months ago (2017-05-15 15:40:25 UTC) #4
Jacob
3 years, 7 months ago (2017-05-15 15:41:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
65e0b8994e0d0b930e1b43e54aa12520ea0c5e2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698