Make ComputedStyleBase a templated class to allow it to use functions on ComputedStyle

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
index c3fa417676719a1b271831bf883904fb2ae33f6b..cc98bc3437826210b5bcd6e7df41e7dc4c68aa7d 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
@@ -46,6 +46,11 @@ struct SameSizeAsComputedStyleBase {
 
 // The generated portion of ComputedStyle. For more info, see the header comment
 // in ComputedStyle.h.
+
+// ComputedStyleBase is a templated class to allow it to use functions

[alancutter (OOO until 2018), 2017/05/12 07:06:22]

This should be clearer that this may only be templated with the ComputedStyle
class, no other class is allowed.

[nainar, 2017/05/12 07:31:33]

Done.

+// on ComputedStyle. This allows us to diff functions on ComputedStyle that

[alancutter (OOO until 2018), 2017/05/12 07:06:22]

*This allows ComputedStyleBase to use hand written functions...

[nainar, 2017/05/12 07:31:33]

Done.

+// ComputedStyleBase would otherwise not know about.
+template <class ComputedStyleFinal>
 class CORE_EXPORT ComputedStyleBase {
  public:
   inline bool IndependentInheritedEqual(const ComputedStyleBase& o) const {
@@ -122,7 +127,7 @@ class CORE_EXPORT ComputedStyleBase {
   }
 
   {% for name, groups_to_diff in diff_functions_map.items() %}
-  bool {{name}}(const ComputedStyleBase& other) const {
+  bool {{name}}(const ComputedStyleFinal& other) const {
     {{fieldwise_diff(groups_to_diff)|indent(2)}}
     return false;
   }
@@ -183,11 +188,6 @@ class CORE_EXPORT ComputedStyleBase {
   {% endfor %}
 };
 
-// If this fails, the packing algorithm in make_computed_style_base.py has
-// failed to produce the optimal packed size. To fix, update the algorithm to
-// ensure that the buckets are placed so that each takes up at most 1 word.
-ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);
-
 } // namespace blink
 
 #endif // ComputedStyleBase_h