Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2879813002: Make ComputedStyleBase a templated class to allow it to use functions on ComputedStyle (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index 329a5db96f9d4a8d6cf215ffb3ec8416d44c3109..8787909d20c0ad782efdc8821b3b18991ffbd003 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -693,10 +693,11 @@ PassRefPtr<ComputedStyle> StyleResolver::StyleForElement(
} else {
if (state.ParentStyle()) {
RefPtr<ComputedStyle> style = ComputedStyle::Create();
- style->InheritFrom(*state.ParentStyle(),
- IsAtShadowBoundary(element)
- ? ComputedStyleBase::kAtShadowBoundary
- : ComputedStyleBase::kNotAtShadowBoundary);
+ style->InheritFrom(
+ *state.ParentStyle(),
+ IsAtShadowBoundary(element)
+ ? ComputedStyleBase<ComputedStyle>::kAtShadowBoundary
+ : ComputedStyleBase<ComputedStyle>::kNotAtShadowBoundary);
alancutter (OOO until 2018) 2017/05/12 06:45:43 Can this just be ComputedStyle::kEnumValue?
nainar 2017/05/12 06:59:18 Yup, Done.
state.SetStyle(std::move(style));
} else {
state.SetStyle(InitialStyleForElement());

Powered by Google App Engine
This is Rietveld 408576698