[subresource_filter] Add a subtitle for Android Page Info

chrome/android/java/res/layout/page_info_permission_row.xml

Index: chrome/android/java/res/layout/page_info_permission_row.xml
diff --git a/chrome/android/java/res/layout/page_info_permission_row.xml b/chrome/android/java/res/layout/page_info_permission_row.xml
index 703bd7eb35f9a70c3bd8784f58ddea870bb34bb3..191299375109b7da85f892f8827a38d81108a7bb 100644
--- a/chrome/android/java/res/layout/page_info_permission_row.xml
+++ b/chrome/android/java/res/layout/page_info_permission_row.xml
@@ -34,4 +34,14 @@
         android:textColor="@color/page_info_popup_text_link"
         android:textSize="14sp"
         android:visibility="gone" />
+
+    <TextView
+        android:id="@+id/page_info_permission_subtitle"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_below="@id/page_info_permission_status"
+        android:layout_toEndOf="@id/page_info_permission_icon"
+        android:lineSpacingExtra="6dp"

[Bernhard Bauer, 2017/05/12 09:24:36]

Where is this value coming from? The linked mocks didn't have any exact
measurements. In Material Design, spacing tends to be often defined in terms of
leading (the distance between subsequent baselines) instead of additional line
spacing, soo... if that is the case here, you could use a
org.chromium.ui.widget.TextViewWithLeading to automatically use the correct line
spacing.

[Charlie Harrison, 2017/05/12 12:31:32]

I used this value to align with the page_info_permission_unavailable_message,
but I don't think it's strictly necessary. Let me check out using
TextViewWithLeading.

[Charlie Harrison, 2017/05/12 15:44:48]

Update: I've checked with UI who confirmed that we want:
Size: 14sp
Color: #8A000000 (secondary_text_default_material_light)
Leading: 20dp

I noticed that no other element here uses TextViewWithLeading, I assume just
using it here should be ok?

[Bernhard Bauer, 2017/05/12 15:51:00]

I think I would use it for the TextView above as well. TextViewWithLeading is
newer than this layout, so I think the only reason it's not used there is
because it wasn't around back then. For for purposes of consistency it would
probably be better to use it there as well.

[Charlie Harrison, 2017/05/12 15:52:29]

Sounds good. Should that have leading 20dp as well?

[Bernhard Bauer, 2017/05/12 15:53:50]

Yes please.

[Charlie Harrison, 2017/05/12 15:58:29]

Done.

+        android:textSize="14sp"
+        android:visibility="gone" />
 </RelativeLayout>