Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h

Issue 2879703003: [chromecast] Moves CastAudioOutputStream::Backend to CMA thread. (Closed)
Patch Set: addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h
diff --git a/chromecast/media/cma/backend/media_pipeline_backend_factory.h b/chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h
similarity index 70%
copy from chromecast/media/cma/backend/media_pipeline_backend_factory.h
copy to chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h
index 087d20e4b25b8d5c11ee69f0d62d5bfcc4ad9483..c2b4bbc9b1979565a488173e13a599d1eed14050 100644
--- a/chromecast/media/cma/backend/media_pipeline_backend_factory.h
+++ b/chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h
@@ -2,13 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_
-#define CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_
-
-#include <memory>
-#include <string>
+#ifndef CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_IMPL_H_
+#define CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_IMPL_H_
#include "base/macros.h"
+#include "chromecast/media/cma/backend/media_pipeline_backend_factory.h"
namespace chromecast {
namespace media {
@@ -18,16 +16,16 @@ class MediaPipelineBackendManager;
struct MediaPipelineDeviceParams;
// Creates MediaPipelineBackends using a given MediaPipelineBackendManager.
-class MediaPipelineBackendFactory {
+class MediaPipelineBackendFactoryImpl : public MediaPipelineBackendFactory {
public:
// TODO(slan): Use a static Create method once all of the constructor
// dependencies are removed from the internal implemenation.
- explicit MediaPipelineBackendFactory(
+ explicit MediaPipelineBackendFactoryImpl(
MediaPipelineBackendManager* media_pipeline_backend_manager);
- virtual ~MediaPipelineBackendFactory();
+ ~MediaPipelineBackendFactoryImpl() override;
- virtual std::unique_ptr<MediaPipelineBackend> CreateBackend(
- const MediaPipelineDeviceParams& params);
+ std::unique_ptr<MediaPipelineBackend> CreateBackend(
+ const MediaPipelineDeviceParams& params) override;
protected:
MediaPipelineBackendManager* media_pipeline_backend_manager() {
@@ -37,10 +35,10 @@ class MediaPipelineBackendFactory {
private:
media::MediaPipelineBackendManager* const media_pipeline_backend_manager_;
- DISALLOW_COPY_AND_ASSIGN(MediaPipelineBackendFactory);
+ DISALLOW_COPY_AND_ASSIGN(MediaPipelineBackendFactoryImpl);
};
} // media
} // chromecast
-#endif // CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_
+#endif // CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698