Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1946)

Unified Diff: chromecast/media/cma/backend/media_pipeline_backend_factory.h

Issue 2879703003: [chromecast] Moves CastAudioOutputStream::Backend to CMA thread. (Closed)
Patch Set: addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/backend/media_pipeline_backend_factory.h
diff --git a/chromecast/media/cma/backend/media_pipeline_backend_factory.h b/chromecast/media/cma/backend/media_pipeline_backend_factory.h
index 087d20e4b25b8d5c11ee69f0d62d5bfcc4ad9483..2f1b010f779d15d41f9750e9f57768c24673d1f0 100644
--- a/chromecast/media/cma/backend/media_pipeline_backend_factory.h
+++ b/chromecast/media/cma/backend/media_pipeline_backend_factory.h
@@ -6,41 +6,23 @@
#define CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_
#include <memory>
-#include <string>
-
-#include "base/macros.h"
namespace chromecast {
namespace media {
class MediaPipelineBackend;
-class MediaPipelineBackendManager;
struct MediaPipelineDeviceParams;
-// Creates MediaPipelineBackends using a given MediaPipelineBackendManager.
+// Abstract base class to create MediaPipelineBackend.
class MediaPipelineBackendFactory {
public:
- // TODO(slan): Use a static Create method once all of the constructor
- // dependencies are removed from the internal implemenation.
- explicit MediaPipelineBackendFactory(
- MediaPipelineBackendManager* media_pipeline_backend_manager);
- virtual ~MediaPipelineBackendFactory();
+ virtual ~MediaPipelineBackendFactory() {}
virtual std::unique_ptr<MediaPipelineBackend> CreateBackend(
- const MediaPipelineDeviceParams& params);
-
- protected:
- MediaPipelineBackendManager* media_pipeline_backend_manager() {
- return media_pipeline_backend_manager_;
- }
-
- private:
- media::MediaPipelineBackendManager* const media_pipeline_backend_manager_;
-
- DISALLOW_COPY_AND_ASSIGN(MediaPipelineBackendFactory);
+ const MediaPipelineDeviceParams& params) = 0;
};
-} // media
-} // chromecast
+} // namespace media
+} // namespace chromecast
#endif // CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_
« no previous file with comments | « chromecast/media/cma/backend/BUILD.gn ('k') | chromecast/media/cma/backend/media_pipeline_backend_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698