Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: chromecast/media/audio/cast_audio_mixer.h

Issue 2879703003: [chromecast] Moves CastAudioOutputStream::Backend to CMA thread. (Closed)
Patch Set: addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/audio/cast_audio_manager_unittest.cc ('k') | chromecast/media/audio/cast_audio_mixer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/audio/cast_audio_mixer.h
diff --git a/chromecast/media/audio/cast_audio_mixer.h b/chromecast/media/audio/cast_audio_mixer.h
index 7927f4259543c0c5eaf5efe5d42a0a77fd016a0f..0a67090725c69a406b65460f10e725d880fa696a 100644
--- a/chromecast/media/audio/cast_audio_mixer.h
+++ b/chromecast/media/audio/cast_audio_mixer.h
@@ -6,7 +6,7 @@
#define CHROMECAST_MEDIA_AUDIO_CAST_AUDIO_MIXER_H_
#include <memory>
-#include <vector>
+#include <set>
#include "base/callback.h"
#include "base/macros.h"
@@ -25,15 +25,11 @@ class CastAudioManager;
// stream down to a single AudioOutputStream to be rendered by the CMA backend.
class CastAudioMixer : public ::media::AudioOutputStream::AudioSourceCallback {
public:
- using RealStreamFactory = base::Callback<::media::AudioOutputStream*(
- const ::media::AudioParameters&)>;
-
- explicit CastAudioMixer(const RealStreamFactory& real_stream_factory);
+ explicit CastAudioMixer(CastAudioManager* audio_manager);
~CastAudioMixer() override;
virtual ::media::AudioOutputStream* MakeStream(
- const ::media::AudioParameters& params,
- CastAudioManager* audio_manager);
+ const ::media::AudioParameters& params);
private:
class MixerProxyStream;
@@ -43,7 +39,6 @@ class CastAudioMixer : public ::media::AudioOutputStream::AudioSourceCallback {
base::TimeTicks delay_timestamp,
int prior_frames_skipped,
::media::AudioBus* dest) override;
-
void OnError() override;
// MixedAudioOutputStreams call Register on opening and AddInput on starting.
@@ -51,17 +46,17 @@ class CastAudioMixer : public ::media::AudioOutputStream::AudioSourceCallback {
void Unregister(MixerProxyStream* proxy_stream);
void AddInput(::media::AudioConverter::InputCallback* input_callback);
void RemoveInput(::media::AudioConverter::InputCallback* input_callback);
+ void HandleError();
- base::ThreadChecker thread_checker_;
- std::unique_ptr<::media::AudioConverter> mixer_;
+ CastAudioManager* const audio_manager_;
bool error_;
-
- const RealStreamFactory real_stream_factory_;
- ::media::AudioOutputStream* output_stream_;
+ std::set<MixerProxyStream*> proxy_streams_;
+ std::unique_ptr<::media::AudioConverter> mixer_;
+ base::Lock mixer_lock_;
::media::AudioParameters output_params_;
+ ::media::AudioOutputStream* output_stream_;
- std::vector<MixerProxyStream*> proxy_streams_;
-
+ THREAD_CHECKER(audio_thread_checker_);
DISALLOW_COPY_AND_ASSIGN(CastAudioMixer);
};
« no previous file with comments | « chromecast/media/audio/cast_audio_manager_unittest.cc ('k') | chromecast/media/audio/cast_audio_mixer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698