Chromium Code Reviews| Index: chromecast/media/cma/backend/media_pipeline_backend_factory.h |
| diff --git a/chromecast/media/cma/backend/media_pipeline_backend_factory.h b/chromecast/media/cma/backend/media_pipeline_backend_factory.h |
| index 087d20e4b25b8d5c11ee69f0d62d5bfcc4ad9483..23ceb9017a28d2533ac31fc5ce0e6dc057ac209f 100644 |
| --- a/chromecast/media/cma/backend/media_pipeline_backend_factory.h |
| +++ b/chromecast/media/cma/backend/media_pipeline_backend_factory.h |
| @@ -6,38 +6,20 @@ |
| #define CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_BACKEND_FACTORY_H_ |
| #include <memory> |
| -#include <string> |
| - |
| -#include "base/macros.h" |
| namespace chromecast { |
| namespace media { |
| class MediaPipelineBackend; |
| -class MediaPipelineBackendManager; |
| struct MediaPipelineDeviceParams; |
| -// Creates MediaPipelineBackends using a given MediaPipelineBackendManager. |
| +// Abstract base class to create MediaPipelineBackend. |
| class MediaPipelineBackendFactory { |
| public: |
| - // TODO(slan): Use a static Create method once all of the constructor |
| - // dependencies are removed from the internal implemenation. |
| - explicit MediaPipelineBackendFactory( |
| - MediaPipelineBackendManager* media_pipeline_backend_manager); |
| - virtual ~MediaPipelineBackendFactory(); |
| + virtual ~MediaPipelineBackendFactory() {} |
| virtual std::unique_ptr<MediaPipelineBackend> CreateBackend( |
| - const MediaPipelineDeviceParams& params); |
| - |
| - protected: |
| - MediaPipelineBackendManager* media_pipeline_backend_manager() { |
| - return media_pipeline_backend_manager_; |
| - } |
| - |
| - private: |
| - media::MediaPipelineBackendManager* const media_pipeline_backend_manager_; |
| - |
| - DISALLOW_COPY_AND_ASSIGN(MediaPipelineBackendFactory); |
| + const MediaPipelineDeviceParams& params) = 0; |
| }; |
| } // media |
|
slan
2017/05/30 16:26:01
nit: namespace here and below
alokp
2017/05/30 23:19:33
Done.
|