[chromecast] Moves CastAudioOutputStream::Backend to CMA thread.

chromecast/browser/cast_content_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_content_browser_client.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 19 matching lines @@
 #include "chromecast/browser/cast_network_delegate.h"
 #include "chromecast/browser/cast_quota_permission_context.h"
 #include "chromecast/browser/cast_resource_dispatcher_host_delegate.h"
 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h"
 #include "chromecast/browser/grit/cast_browser_resources.h"
 #include "chromecast/browser/media/media_caps_impl.h"
 #include "chromecast/browser/service/cast_service_simple.h"
 #include "chromecast/browser/url_request_context_factory.h"
 #include "chromecast/common/global_descriptors.h"
 #include "chromecast/media/audio/cast_audio_manager.h"
-#include "chromecast/media/cma/backend/media_pipeline_backend_factory.h"
+#include "chromecast/media/cma/backend/media_pipeline_backend_factory_impl.h"
 #include "chromecast/media/cma/backend/media_pipeline_backend_manager.h"
 #include "chromecast/public/media/media_pipeline_backend.h"
 #include "components/crash/content/app/breakpad_linux.h"
 #include "components/crash/content/browser/crash_handler_host_linux.h"
 #include "components/network_hints/browser/network_hints_message_filter.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/certificate_request_result_type.h"
 #include "content/public/browser/client_certificate_delegate.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_dispatcher_host.h"
@@ skipping 119 matching lines @@
 CastContentBrowserClient::GetMediaTaskRunner() {
   DCHECK(cast_browser_main_parts_);
   return cast_browser_main_parts_->GetMediaTaskRunner();
 }
 
 media::MediaPipelineBackendFactory*
 CastContentBrowserClient::GetMediaPipelineBackendFactory() {
   DCHECK(GetMediaTaskRunner()->BelongsToCurrentThread());
   if (!media_pipeline_backend_factory_) {
     media_pipeline_backend_factory_.reset(
-        new media::MediaPipelineBackendFactory(
+        new media::MediaPipelineBackendFactoryImpl(
             media_pipeline_backend_manager()));
   }
   return media_pipeline_backend_factory_.get();
 }
 
 media::MediaResourceTracker*
 CastContentBrowserClient::media_resource_tracker() {
   return cast_browser_main_parts_->media_resource_tracker();
 }
 
 media::MediaPipelineBackendManager*
 CastContentBrowserClient::media_pipeline_backend_manager() {
   DCHECK(cast_browser_main_parts_);
   return cast_browser_main_parts_->media_pipeline_backend_manager();
 }
 
 std::unique_ptr<::media::AudioManager>
 CastContentBrowserClient::CreateAudioManager(
     ::media::AudioLogFactory* audio_log_factory) {
+  // TODO(alokp): Consider switching off the mixer on audio platforms

[slan, 2017/05/30 16:26:01]

Is this comment useful? Aren't we blocked on dmix issues?

[alokp, 2017/05/30 23:19:33]

Not really - We can switch off the CastAudioManager mixer today on audio
platforms because mixer is implemented in CMA-Alsa wrapper, which sits upstream
of alsa/dmix.

[slan, 2017/05/30 23:44:39]

Ah, I see what you mean - disable the mixer whenever the alsa CMA backend is
used. Vendors (who may or may not use the alsa CMA backend) should still get
this functionality. 

+  // because we already have a mixer in the audio pipeline downstream of
+  // CastAudioManager.
+  bool use_mixer = true;
   return base::MakeUnique<media::CastAudioManager>(
       base::MakeUnique<::media::AudioThreadImpl>(), audio_log_factory,
-      media_pipeline_backend_manager());
+      base::MakeUnique<media::MediaPipelineBackendFactoryImpl>(
+          media_pipeline_backend_manager()),
+      GetMediaTaskRunner(), use_mixer);
 }
 
 std::unique_ptr<::media::CdmFactory>
 CastContentBrowserClient::CreateCdmFactory() {
 #if BUILDFLAG(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)
   return base::MakeUnique<media::CastCdmFactory>(GetMediaTaskRunner(),
                                                  media_resource_tracker());
 #endif  // BUILDFLAG(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)
   return nullptr;
 }
@@ skipping 359 matching lines @@
         process_type, dumps_path, false /* upload */);
   // StartUploaderThread() even though upload is diferred.
   // Breakpad-related memory is freed in the uploader thread.
   crash_handler->StartUploaderThread();
   return crash_handler;
 }
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace shell
 }  // namespace chromecast