Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/version_info/version_info.cc

Issue 2879703002: WebView: Add channel info for UMA (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_info/version_info.h ('k') | components/version_info/version_string.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info/version_info.cc
diff --git a/components/version_info/version_info.cc b/components/version_info/version_info.cc
index b12ad0ff687cad0c89736d9461bf9c4e5fa9517a..0b28f1523900552b7decc2f7c195d1d2d53f2b9c 100644
--- a/components/version_info/version_info.cc
+++ b/components/version_info/version_info.cc
@@ -5,7 +5,6 @@
#include "components/version_info/version_info.h"
#include "build/build_config.h"
-#include "components/strings/grit/components_strings.h"
#include "components/version_info/version_info_values.h"
#if defined(USE_UNOFFICIAL_VERSION_NUMBER)
@@ -83,21 +82,4 @@ std::string GetChannelString(Channel channel) {
return std::string();
}
-std::string GetVersionStringWithModifier(const std::string& modifier) {
- std::string current_version;
- current_version += GetVersionNumber();
-#if defined(USE_UNOFFICIAL_VERSION_NUMBER)
- current_version += " (";
- current_version += l10n_util::GetStringUTF8(IDS_VERSION_UI_UNOFFICIAL);
- current_version += " ";
- current_version += GetLastChange();
- current_version += " ";
- current_version += GetOSType();
- current_version += ")";
-#endif // USE_UNOFFICIAL_VERSION_NUMBER
- if (!modifier.empty())
- current_version += " " + modifier;
- return current_version;
-}
-
} // namespace version_info
« no previous file with comments | « components/version_info/version_info.h ('k') | components/version_info/version_string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698