android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java - Issue 2879703002: WebView: Add channel info for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2879703002: WebView: Add channel info for UMA (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_metrics_service_client.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

index 9d0138fa35948615e434a3292717dad2827e036e..f1379e33649ac438a8e62664d85f32ce0e2fb15b 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

@@ -417,6 +417,7 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {

// The WebView package name is used to locate the separate Service to which we copy crash

// minidumps. This package name must be set before a render process has a chance to crash -

// otherwise we might try to copy a minidump without knowing what process to copy it to.

+ // It's also used to determine channel for UMA, so it must be set before initializing UMA.

AwBrowserProcess.setWebViewPackageName(webViewPackageName);

AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, isExternalService);

AwBrowserProcess.start();