components/version_info/channel_android.h - Issue 2879703002: WebView: Add channel info for UMA

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/version_info/channel_android.h

Issue 2879703002: WebView: Add channel info for UMA (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_VERSION_INFO_CHANNEL_ANDROID_H_

	6 #define COMPONENTS_VERSION_INFO_CHANNEL_ANDROID_H_

	7

	8 #include "components/version_info/channel.h"

	9

	10 namespace version_info {

	11

	12 Channel ChannelFromPackageName(const char* name);
	Alexei Svitkine (slow) 2017/05/12 14:26:22 Nit: package_name Also add a short 1-line comment Nit: package_name Also add a short 1-line comment. paulmiller 2017/05/12 19:45:35 Done. Show quoted text On 2017/05/12 14:26:22, Alexei Svitkine (slow) wrote: > Nit: package_name > > Also add a short 1-line comment. Done.
	13

	14 } // namespace version_info

	15

	16 #endif // COMPONENTS_VERSION_INFO_CHANNEL_ANDROID_H_

OLD	NEW