Issue 2879663002: dom: Recognize __getter__ indexers

Issue 2879663002: dom: Recognize getter indexers (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
terry, Alan Knight

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dom: Recognize __getter__ indexers BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/f3734a9fc50860c2ac395fb8b83e7d81d048b41b

Patch Set 1 #

Total comments: 1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -7 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	8 chunks	+18 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alan Knight

LGTM, with a query https://codereview.chromium.org/2879663002/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (left): https://codereview.chromium.org/2879663002/diff/1/tools/dom/scripts/htmlrenamer.py#oldcode91 tools/dom/scripts/htmlrenamer.py:91: 'DataView', # Typed arrays Is ...

3 years, 7 months ago (2017-05-11 20:10:18 UTC) #4

sra1

3 years, 7 months ago (2017-05-11 20:59:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f3734a9fc50860c2ac395fb8b83e7d81d048b41b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages