third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 76494dc4ec00c89ce559781ab36aa1741870862d..87d28711184c6b20813ace2ad7b573aad6a40f0d 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -571,7 +571,7 @@ bool ComputedStyle::ScrollAnchorDisablingPropertyChanged(

return true;

}

- if (ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other, diff))

+ if (ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other))

return true;

if (diff.TransformChanged())