Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
new file mode 100644
index 0000000000000000000000000000000000000000..0d2ef6913d53b8e0061ae8b055f8e58994dbf14f
--- /dev/null
+++ b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
@@ -0,0 +1,33 @@
+{
+// This file specifies the fields we want to diff in the various diff functions
+//in ComputedStyle.
+
+ parameters: {
+ // The name parameter represents the name of the function to be created.
+
+ // The fields that need to be diffed.
+ fields: {
+ },
+
+ // A map of expressions to diff (these can be public getters of fields or
+ // functions that use fields to determine a value).
+ // TODO: Not implemented for now.
+ map_of_expressions: {
+ default: {},
+ },
+
+ },
+ data: [
+ {
+ name: "ScrollAnchorDisablingPropertyChanged",
+ fields: ["margin-top", "margin-left", "margin-right", "margin-bottom",
+ "left", "right", "top", "bottom", "padding-top",
+ "padding-left", "padding-right", "padding-bottom"]
+ },
+ {
+ name: "DiffNeedsFullLayoutAndPaintInvalidation",
+ fields: ["padding-top", "padding-left", "padding-right",
+ "padding-bottom"]
+ }
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698