| OLD | NEW |
|---|
| 1 {% macro encode(field, value) %} | 1 {% macro encode(field, value) %} |
| 2 {% if field.is_bit_field -%} | 2 {% if field.is_bit_field -%} |
| 3 static_cast<unsigned>({{value}}) | 3 static_cast<unsigned>({{value}}) |
| 4 {%- else -%} | 4 {%- else -%} |
| 5 {{value}} | 5 {{value}} |
| 6 {%- endif %} | 6 {%- endif %} |
| 7 {% endmacro %} | 7 {% endmacro %} |
| 8 | 8 |
| 9 {% macro decode(field, value) %} | 9 {% macro decode(field, value) %} |
| 10 {% if field.is_bit_field -%} | 10 {% if field.is_bit_field -%} |
| (...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 89 {{subgroup.member_name}} = other.{{subgroup.member_name}}; | 89 {{subgroup.member_name}} = other.{{subgroup.member_name}}; |
| 90 {% elif subgroup.fields|select("in", fields_to_copy)|list|length > 0 -%} | 90 {% elif subgroup.fields|select("in", fields_to_copy)|list|length > 0 -%} |
| 91 {{fieldwise_copy(subgroup, fields_to_copy)}} | 91 {{fieldwise_copy(subgroup, fields_to_copy)}} |
| 92 {% endif %} | 92 {% endif %} |
| 93 {% endfor %} | 93 {% endfor %} |
| 94 {% for field in group.fields|select("in", fields_to_copy) -%} | 94 {% for field in group.fields|select("in", fields_to_copy) -%} |
| 95 {{setter_expression(field)}} = other.{{getter_expression(field)}}; | 95 {{setter_expression(field)}} = other.{{getter_expression(field)}}; |
| 96 {% endfor %} | 96 {% endfor %} |
| 97 {% endmacro %} | 97 {% endmacro %} |
| 98 | 98 |
| 99 {% macro fieldwise_diff(group, fields_to_diff) %} | 99 {% macro fieldwise_diff(group_to_diff) %} |
| 100 {% for subgroup in group.subgroups %} | 100 {% for group in group_to_diff.subgroups %} |
| 101 {% if subgroup.all_fields|select("in", fields_to_diff)|list|length > 0 -%} | 101 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) { |
| 102 if ({{subgroup.member_name}}.Get() != other.{{subgroup.member_name}}.Get()) { | 102 {{fieldwise_diff(group)|indent(2, true)}} |
| 103 {{fieldwise_diff(subgroup, fields_to_diff)|indent(2, true)}} | |
| 104 } | 103 } |
| 105 {% endif -%} | |
| 106 {% endfor %} | 104 {% endfor %} |
| 107 {% for field in group.fields|select("in", fields_to_diff) %} | 105 {% for expression in group_to_diff.expressions %} |
| 108 if ({{getter_expression(field)}} != other.{{getter_expression(field)}}) | 106 if ({{expression}} != other.{{expression}}) |
| 109 return true; | 107 return true; |
| 110 {% endfor %} | 108 {% endfor %} |
| 111 {% endmacro %} | 109 {% endmacro %} |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2879563002:
Refactor code generation to allow us to diff generic expressions and not just fields (Closed)
