third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl - Issue 2879493003: Check if value changed when setting nested fields in ComputedStyleBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

Issue 2879493003: Check if value changed when setting nested fields in ComputedStyleBase. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

index 01f0bdc44c67216a944aa84122279ef7ba03673e..cf9a71549596ba006f628ae961a8ee77639e5ced 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl

@@ -1,10 +1,10 @@

{% import 'fields/base.tmpl' as base %}

-{% from 'fields/field.tmpl' import encode, setter_expression %}

+{% from 'fields/field.tmpl' import encode, set_if_changed %}

{% macro decl_public_methods(field) %}

void {{field.setter_method_name}}() {

- {{setter_expression(field)}} = {{encode(field, "true")}};

+ {{set_if_changed(field, encode(field, "true"))|indent(2)}}

}

{% endmacro %}

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | no next file » | no next file with comments »